Skip to content

[CI] Minor cleanup and more consistent workflow names #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 23, 2025
Merged

[CI] Minor cleanup and more consistent workflow names #158

merged 23 commits into from
May 23, 2025

Conversation

ckadner
Copy link
Collaborator

@ckadner ckadner commented May 14, 2025 •
edited
Loading

Minor changes for easier onboarding and maintainability:

  • Rename actions for consistency, based on semantics, not interchangeable technology, i.e.
    • actionlint --> lint_actions.yml
    • ruff --> lint_code.yml
    • doc-lint --> lint_docs.yml
    • shellcheck --> lint_scripts.yml
    • mypy --> typecheck.yml
  • Remove references to old requirements files
  • Keep Dockerfile for time being
  • Consistently use underscore, not dash in filenames
  • Rename files corresponding to workflow files in /tools (keep file names under /matchers as those are tightly coupled to specific tools)

TODO:

After merging this PR, rename expected PR checks (repo admin)

  • Update main branch protection rules, Merge requirements:
    • Remove ruff -- Add lint-code
    • Remove mypy --> Add type-check

ckadner added 5 commits April 15, 2025 20:15
@ckadner
[CI] Cleanup files and file names
97fcf74 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Merge branch 'main' into ci_cleanup
2208b20 
Signed-off-by: Christian Kadner <[email protected]>

# Conflicts:
#	.github/workflows/lint_docs.yml
#	.github/workflows/scripts/build.sh
@ckadner
Merge branch 'main' into ci_cleanup
7147783
@ckadner
Reinstate Dockerfile
e2a38fd 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Re-instate branch filters
bebb103 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner requested a review from joerunde May 14, 2025 16:22
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@ckadner ckadner marked this pull request as draft May 14, 2025 16:23
joerunde
joerunde reviewed May 21, 2025
View reviewed changes
joerunde
joerunde approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPGTM!

Let's grab some time together to get this merged and update the repo settings

@joerunde joerunde marked this pull request as ready for review May 22, 2025 22:07
joerunde
joerunde reviewed May 22, 2025
View reviewed changes
ckadner added 6 commits May 22, 2025 16:19
@ckadner
Merge branch 'main' into ci_cleanup
b089908 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Merge branch 'main' into ci_cleanup
11a019a
@ckadner
Force actionlint errors
ea62eed 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Let actionlint fail-on-error
d415756 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Remove forced actionlint errors
d1efbc2 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Remove TODOs
0e2b975 
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner changed the title [WIP][Ci] Minor cleanup and more consistent workflow names [CI] Minor cleanup and more consistent workflow names May 22, 2025
@joerunde joerunde enabled auto-merge (squash) May 23, 2025 18:31
@github-actions github-actions bot added the ready label May 23, 2025
@joerunde joerunde disabled auto-merge May 23, 2025 18:32
@joerunde joerunde enabled auto-merge (squash) May 23, 2025 18:33
@ckadner ckadner disabled auto-merge May 23, 2025 18:35
@ckadner ckadner enabled auto-merge (squash) May 23, 2025 18:35
@ckadner ckadner merged commit da7692e into vllm-project:main May 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joerunde joerunde joerunde approved these changes

Assignees

No one assigned

Labels

ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ckadner @joerunde